-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Select which adblock data files to generate using cli args #699
Conversation
7ba2fa2
to
68a13ef
Compare
68a13ef
to
bd592a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tontinton thanks for submitting this!
Unfortunately there are a few dependencies between components that are left in for historical reasons, e.g. the regional data files depend on the default component files here.
I'm hoping to get rid of those dependencies eventually, but I don't want to suddenly break things for older browser versions that haven't updated in a while. In the meantime we still have to do most† of these in order.
So, I can't merge this just yet, but hopefully I can get to it in the future.
† I say "most" because the test data files can definitely be generated in parallel... but those can probably be removed altogether, too. I don't believe we have any code that would be using them anymore (#701).2f76717
to
04d89fc
Compare
549bb86
to
0c772df
Compare
Ok I updated the PR to only include the cli stuff, will be useful for me (I want to generate only the default list) |
8d9f2a9
to
7c9a022
Compare
50a3e96
to
bb12e7f
Compare
bb12e7f
to
f34576c
Compare
f34576c
to
e89f54e
Compare
bumping, still keeping a fork :( regional lists sometimes return 404, while the default seems to work all the time. |
another final bump? 😅 |
@tontinton sorry for the delay, but the reorganization in #844 should make this significantly easier. All the components will be "self-contained", i.e. not dependent on other component jobs running. Going forward:
|
No description provided.