Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cancel event does not fired when copy: true #685

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

PFight
Copy link

@PFight PFight commented Sep 9, 2021

Fix for #680 and #684

@ignaciostellino
Copy link

ignaciostellino commented Dec 7, 2022

When this will be merged and we can benefit of these fixes? @PFight @bevacqua

@@ -1,6 +1,6 @@
{
"name": "dragula",
"version": "3.7.3",
"name": "dragula-fixed",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This attribute should not change

Suggested change
"name": "dragula-fixed",
"name": "dragula",

dragula.js Outdated
Comment on lines 566 to 572
function getParent (el) {
if (el) {
return el.parentNode === doc ? null : el.parentNode;
} else {
return null;
}
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would be easier to maintain

Suggested change
function getParent (el) {
if (el) {
return el.parentNode === doc ? null : el.parentNode;
} else {
return null;
}
}
function getParent (el) { return el && el.parentNode !== doc ? el.parentNode : null; }
}

@ignaciostellino
Copy link

thank you @toofff , but now to use the fix we need that someone with write access publish this new version. How we can speed that?

@toofff
Copy link

toofff commented Dec 9, 2022

@ignaciostellino You have to see with @LeaVerou ;)

@LeaVerou
Copy link
Collaborator

LeaVerou commented Dec 9, 2022

Sorry folks, I reached out to @bevacqua to be added as a maintainer during a period I had a lot of time for Dragula and had started a v2 rewrite, but by the time I was actually added, I was too swamped with other things and didn’t have time anymore. At this point, I don't know if I ever will. @bevacqua feel free to remove me if that makes more sense.

[BUG] Fix cancel revert with copy and copySortSource
@toofff
Copy link

toofff commented Dec 14, 2022

For my part, I have a version that fixes a lot of things (it takes over the fixes from certain PRs or issues and part of the work of @LeaVerou) and can be an implementation with typescript, if I manage to plan some time for myself. end of the month.

Maybe following his modifications I could see with @bevacqua to continue to maintain his project?

@ignaciostellino
Copy link

For my part, I have a version that fixes a lot of things (it takes over the fixes from certain PRs or issues and part of the work of @LeaVerou) and can be an implementation with typescript, if I manage to plan some time for myself. end of the month.

Maybe following his modifications I could see with @bevacqua to continue to maintain his project?

@toofff that will be great if we can benefit from the fixes of the comunity and have a new version available :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants