Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirror image issues #601

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Mirror image issues #601

wants to merge 2 commits into from

Conversation

leachryan
Copy link

Fixed a performance issue occurring when dragging an element that contains child elements. A mirror image was being created for each child image as well as the containing element. This lead to performance issues when starting to drag and waiting for elements to settle, so that the element could be dropped. This fix just checks if a mirror image already exists, and if so, doesn't append another one.

Ryan Leach added 2 commits January 23, 2019 16:20
Fixed a performance issue occurring when dragging an element that contains child elements. A mirror image was being created for each child image as well as the containing element. This lead to performance issues when starting to drag and waiting for elements to settle, so that the element could be dropped. This fix just checks if a mirror image already exists, and if so, doesn't append another one.
Removed console.log statements previously commited
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant