Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/DEVSU-2384-permission-storage-improvement #381

Open
wants to merge 22 commits into
base: develop
Choose a base branch
from

Conversation

Nithriel
Copy link
Contributor

Improvement:

  • Improve user group handling

@Nithriel Nithriel self-assigned this Aug 28, 2024
Copy link

Unit Test Results

    1 files  ±0    59 suites  ±0   2m 36s ⏱️ +3s
535 tests  - 6  535 ✔️  - 6  0 💤 ±0  0 ❌ ±0 
532 runs   - 6  532 ✔️  - 6  0 💤 ±0  0 ❌ ±0 

Results for commit 56617e2. ± Comparison against base commit 2bbc216.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 90.62500% with 3 lines in your changes missing coverage. Please review.

Project coverage is 77.90%. Comparing base (2bbc216) to head (56617e2).

Files with missing lines Patch % Lines
app/routes/user/member.js 66.66% 1 Missing and 1 partial ⚠️
app/middleware/group.js 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #381      +/-   ##
===========================================
- Coverage    77.94%   77.90%   -0.05%     
===========================================
  Files          168      167       -1     
  Lines         5646     5604      -42     
  Branches       655      658       +3     
===========================================
- Hits          4401     4366      -35     
+ Misses        1179     1170       -9     
- Partials        66       68       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants