Fix infoplist exclusivity / config inhertiance #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original version required that infoplists_by_build_setting and xcconfig_by_build_setting are mutually exclusive which was problematic for people who had different condtions. To remidate this problem, let build configuration pick _one_: move xcconfig_by_build_setting into a select() statement as-is so it is selected by configuration Finally remove the "select" statement inheritance. From an API perspectie a select isn't inherited so we will only inherit from `xcconfig`. This is a breaking change if you relied on the previous behavior ( which was only a couple days ago )
|
cc @luispadron this addresses a few followups from the recent PR. The one change we might need to fix for your use case is the |
luispadron
reviewed
Nov 30, 2022
Comment on lines
+44
to
+45
| if len(infoplists_by_build_setting.keys()) == 0: | ||
| infoplists_by_build_setting["//conditions:default"] = default_infoplists |
There was a problem hiding this comment.
I guess the confusing part is this differs from how xcconfig and xcconfig_by_build_setting work.
xcconfig gets merged into all the different ones but this seems to ignore infoplists entirely if infoplists_by_build_setting is set
There was a problem hiding this comment.
If we dont want users to use them both at the same time (cash doesn't use infoplists_by_build_setting at all) should we just fail instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original version required that infoplists_by_build_setting and xcconfig_by_build_setting are mutually exclusive which was problematic for people who had different condtions. To remidate this problem, let build configuration pick one: move xcconfig_by_build_setting into a select() statement as-is so it is selected by configuration
Finally remove the "select" statement inheritance. From an API perspectie a select isn't inherited so we will only inherit from
xcconfig. This is a breaking change if you relied on the previous behavior ( which was only a couple days ago )