Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rds): support minor versions for RDS for SQL Server #31491

Merged
merged 3 commits into from
Sep 20, 2024

Conversation

go-to-k
Copy link
Contributor

@go-to-k go-to-k commented Sep 19, 2024

Issue # (if applicable)

Closes #.

Reason for this change

This PR supports engine versions for RDS for SQL Server.

  • SQL Server 2016 - 13.00.6445.1
  • SQL Server 2017 - 14.00.3475.1
  • SQL Server 2019 - 15.00.4390.2
  • SQL Server 2022 - 16.00.4140.3

https://aws.amazon.com/about-aws/whats-new/2024/09/amazon-rds-sql-server-minor-versions-september-2024/

❯ aws rds describe-db-engine-versions --engine sqlserver-ee --query "DBEngineVersions[?EngineVersion=='13.00.6445.1.v1'||EngineVersion=='14.00.3475.1.v1'||EngineVersion=='15.00.4390.2.v1'||EngineVersion=='16.00.4140.3.v1'].[DBEngineVersionDescription,EngineVersion,DBParameterGroupFamily,MajorEngineVersion,Status]"
[
    [
        "SQL Server 2016 13.00.6445.1.v1",
        "13.00.6445.1.v1",
        "sqlserver-ee-13.0",
        "13.00",
        "available"
    ],
    [
        "SQL Server 2017 14.00.3475.1.v1",
        "14.00.3475.1.v1",
        "sqlserver-ee-14.0",
        "14.00",
        "available"
    ],
    [
        "SQL Server 2019 15.00.4390.2.v1",
        "15.00.4390.2.v1",
        "sqlserver-ee-15.0",
        "15.00",
        "available"
    ],
    [
        "SQL Server 2022 16.00.4140.3.v1",
        "16.00.4140.3.v1",
        "sqlserver-ee-16.0",
        "16.00",
        "available"
    ]
]

Description of changes

Description of how you validated changes

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team September 19, 2024 05:25
@github-actions github-actions bot added p2 distinguished-contributor [Pilot] contributed 50+ PRs to the CDK labels Sep 19, 2024
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Sep 19, 2024
Copy link
Contributor

mergify bot commented Sep 19, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Sep 19, 2024
Copy link
Contributor

mergify bot commented Sep 19, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@sumupitchayan
Copy link
Contributor

@go-to-k approved, but can you check out why the build is failing?

@go-to-k
Copy link
Contributor Author

go-to-k commented Sep 20, 2024

@sumupitchayan

Thanks for your approval. The cause seems to be unrelated to this PR. I will retry.

@go-to-k
Copy link
Contributor Author

go-to-k commented Sep 20, 2024

@Mergifyio update

Copy link
Contributor

mergify bot commented Sep 20, 2024

update

✅ Branch has been successfully updated

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 7050557
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Sep 20, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit d6f6f56 into aws:main Sep 20, 2024
9 checks passed
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2024
@go-to-k go-to-k deleted the rds-sql-server-minor branch September 20, 2024 01:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants