feat(s3-deployment): added property outputObjectKeys for BucketDeployment #31452
+13,157
−37,235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
bug
1 task
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
aws-cdk-automation
added
the
pr/needs-maintainer-review
Leo10Gama
requested changes
Sep 16, 2024
| * | ||
| * See https://github.com/aws/aws-cdk/issues/28579 | ||
| * | ||
| * @default true |
There was a problem hiding this comment.
Might be missing it, but is there somewhere in the code we are defaulting this value to true? The closest thing I can find is ../product-stack-synthesizer.ts, but that sets it to false.
There was a problem hiding this comment.
its value is set to true here
.. but you have a point, we should set it to true as well in the construct
Comment on lines
+1722
to
+1724
| Template.fromStack(stack).hasResourceProperties('Custom::CDKBucketDeployment', { | ||
| OutputObjectKeys: false, | ||
| }); |
There was a problem hiding this comment.
Should we also verify that the previous behaviour still exists as well? That is, have a unit test to check that when OutputObjectKeys is true, the object keys are in the output?
There was a problem hiding this comment.
May also be worth having a test to verify the default value of the attribute
aws-cdk-automation
removed
the
pr/needs-maintainer-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #28579
Reason for this change
The CR lambda is essentially sending back the same data in the response which is hitting the limit for close to 50 object uploads.
Particularly this is being a limitation when using servicecatalog.ProductStack, if there are local assets beyond a particular number, the Custom::CDKBucketDeployment would fail with the error Response object is too long which is a hard limit of 4096 bytes.
Description of changes
outputObjectKeyshas been set to false by default for the service catalog product so that the error does not occur.Description of how you validated changes
Validated using a sample stack with the property set and confirmed the behavior. Also, the existing deployments would be unaffected.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license