chore(lambda-event-sources): starting position timestamp for kafka #31439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
p2
valued-contributor
aws-cdk-automation
added
the
pr/needs-community-review
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
could you please add a new GH issue as a Feature request, and link it to this issue. |
moelasmar
requested changes
Sep 16, 2024
aws-cdk-automation
removed
the
pr/needs-community-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this change
It was impossible to start consuming a Kafka topic from a specific point in time.
Description of changes
The user may now set
startingPositionTimestamptoManagedKafkaEventSourceandSelfManagedKafkaEventSourceto start consuming a Kafka topic from a specific point in time.Lambda and CloudFormation have supported the functionality for a while, and other stream event sources like
KinesisEventSourcealready had a CDK implementation for it, so there's nothing new under the sky — just expanding it to cover sources we are using :)Description of how you validated changes
The change is tested by adding similar unit tests to other event sources supporting this functionality.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license