Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add possibility to add more than one container in container-name #229

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

felipem1210
Copy link

Issue #, if available: #228

Description of changes:

In this PR I'm adding the possibilty to pass more than one container inside container-name input. The container names can be passed comma separated. The same image and environment variables will be applied to all the containers

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@DragosDumitrache
Copy link

Just want to say, can't wait for this feature to be merged in, it's going to be particularly helpful!

@amazreech
Copy link
Contributor

Hi @felipem1210, thank you so much for your contribution. Apologies on the delay. We will be working on reviewing Pull Requests on the repositories. In the mean time please ensure that below steps, if not already done, are taken care of in your PR:

  1. Verify if PR follows semantic pull request conventions.

  2. Please run npm run package command to update dist/ folder with latest dependencies.

  3. Resolve merge conflicts on the PR if any.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants