-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix number can't be shared #130
Open
Mugisha146
wants to merge
1
commit into
develop
Choose a base branch
from
117-phone-numbers-can-be-shared
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Code Climate has analyzed commit 11db79c and detected 0 issues on this pull request. View more on Code Climate. |
Mugisha146
requested review from
mutsinziisaac,
mugishaj092 and
SaddockAime
September 14, 2024 18:43
Mugisha146
added
Ready For Review
Extra attention is needed
frontend
frontend task
DREAM
DREAM TEAM
labels
Sep 14, 2024
robsdagreat
approved these changes
Sep 16, 2024
mutsinziisaac
approved these changes
Sep 16, 2024
mugishaj092
approved these changes
Sep 17, 2024
mugishaj092
approved these changes
Sep 17, 2024
SaddockAime
approved these changes
Sep 17, 2024
SHYAKA-Aime
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Task : #117 - Phone number can’t be shared
description : To prevent multiple users from registering with the same phone number ( ensures each phone number can only be associated with a single user account).
Describe your changes
i added a validation checker that check if Telephone number already exists or used in register process by someone else then display toast to notify him/her.
PR Type
What kind of change does this PR introduce?
[ *] Bugfix
[ ] Feature
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Tests
[ ] Other
How should this be manually tested?
Issuelink
Screenshots (if is appropriate)