Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP extensions binary classifiers #2585

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

LaurentGoderre
Copy link
Contributor

No description provided.

@LaurentGoderre LaurentGoderre force-pushed the php-extensions-bin branch 3 times, most recently from dae61bd to 70531bb Compare February 5, 2024 14:57
@LaurentGoderre LaurentGoderre marked this pull request as ready for review February 5, 2024 14:58
@spiffcs
Copy link
Contributor

spiffcs commented Feb 6, 2024

Thanks for the updates here @LaurentGoderre! I've got some time this afternoon and can give this a look.

@spiffcs spiffcs self-requested a review February 6, 2024 19:28
}

//nolint:funlen
func phpExtensionsClassifiers() []Classifier {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't quite understand the need for so many classifiers, can you help me understand what this is doing? (this should also probably be captured as a comment in the code)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are extensions for which the source exists in the PHP codebase but aren't compiled in the main PHP binary. They are optionally compiled when users need it. ex: https://github.com/nextcloud/docker/blob/master/28/fpm-alpine/Dockerfile#L41-L53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants