Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: change node.js version to 18,20 and update actions version #2604

Merged
merged 2 commits into from
Jul 18, 2024
Merged

ci: change node.js version to 18,20 and update actions version #2604

merged 2 commits into from
Jul 18, 2024

Conversation

liuyib
Copy link
Collaborator

@liuyib liuyib commented Jul 17, 2024 •
edited
Loading

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

CI error

🔗 Related issue link

💡 Background and solution

image

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

liuyib
liuyib commented Jul 17, 2024
View reviewed changes
.github/workflows/node-ci.yml
Copy link
Collaborator Author

@liuyib liuyib Jul 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个文件和 test.yml 逻辑重复了，所以删除了

crazylxr
crazylxr approved these changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@crazylxr crazylxr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazylxr crazylxr merged commit 2bc738f into master Jul 18, 2024
11 checks passed
@crazylxr crazylxr deleted the ci_fix_node_version branch July 18, 2024 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazylxr crazylxr crazylxr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liuyib @crazylxr