SSCursor: Fix connection closed check #991
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Since the connection closes itself on an
asyncio.CancelledError
, it cannot be used afterwards.SSCursor.close
attempts to clear some unfinished state first before closing usingConnection._finish_unbuffered_query
, but that call fails if the connection has been closed already and SSCursor itself does not properly check that.Are there changes in behavior for the user?
Cancellations now do not raise an unhandled exception anymore when using the connection and the SSCursor in a context manager.
Following is an example traceback where both the connection and the SSCursor are used in an AsyncExitStack and the task was cancelled:
Related issue number
Checklist