Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add per-file-ignores mention in violations.rst #1914

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Paciupa
Copy link

@Paciupa Paciupa commented Feb 7, 2024

There is no mention of "per-file-ignores" option in "Selecting and Ignoring Violations" section documentation, only in "Full Listing of Options and Their Descriptions".

There is no mention of "per-file-ignores" option in "Selecting and Ignoring Violations" section documentation, only in "Full Listing of Options and Their Descriptions".
@Paciupa Paciupa marked this pull request as ready for review February 7, 2024 12:34
docs/source/user/violations.rst Outdated Show resolved Hide resolved
docs/source/user/violations.rst Outdated Show resolved Hide resolved
docs/source/user/violations.rst Show resolved Hide resolved
docs/source/user/violations.rst Outdated Show resolved Hide resolved
docs/source/user/violations.rst Outdated Show resolved Hide resolved
Paciupa

This comment was marked as duplicate.

Paciupa

This comment was marked as duplicate.

@asottile
Copy link
Member

asottile commented Feb 7, 2024

should this just link to the docs which already describe this option rather than duplicating it but slightly differently?

@Paciupa
Copy link
Author

Paciupa commented Feb 7, 2024

Maybe, but section Extending the Default Ignore List section describes --extend-ignore key the same way.

@asottile
Copy link
Member

asottile commented Feb 7, 2024

that should probably go away then too!

@Paciupa
Copy link
Author

Paciupa commented Feb 8, 2024

So, should I close this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants