Metaflow Configs #1962
Open
Metaflow Configs #1962
+1,470
−154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romain-intel
force-pushed
the
feat/configs
branch
3 times, most recently
from
b03a453
to
de97829
Compare
|
As a user interested in using a config file instead of using different sets of parameters, what would a config file look like? |
|
@bhogan-bdai -- the idea so far is to support a simple format like JSON (nested dicts basically) but other formats could be supported as well. We are also providing a |
Previously, options like `branch` and `name` (injected by the project decorator for example) could be set using `METAFLOW_BRANCH`. They now need to be set using `METAFLOW_FLOW_BRANCH`. This change is made to prevent clashes between regular metaflow configuration settings and decorator level options. No other changes are made so `METAFLOW_RUN_MAX_WORKERS` still works as expected and `METAFLOW_PYLINT` as well.
Several fixes: - fixed an issue with default values - better handling of parameter defaults as configs - handle config defaults as functions - ConfigValue is more "dict"-like - made <myflow>.configs and <myflow>.steps work properly - renamed resolve_configs to init
Specifically: - moved things out of the INFO file - added to_dict - renamed user_configs to config_parameters
Specifically: - made config values immutable - cleaned up state stored in FlowSpec - added a test exercising configs in various places
romain-intel
force-pushed
the
feat/configs
branch
from
a4b601d
to
bcdd987
Compare
Will only print stuff when there is an error and will print it in a non-interleaved manner.
saikonen
reviewed
Sep 12, 2024
| @@ -135,8 +135,8 @@ class KubernetesDecorator(StepDecorator): | |||
| package_sha = None | |||
| run_time_limit = None | |||
|
|
|||
| def __init__(self, attributes=None, statically_defined=False): | |||
| super(KubernetesDecorator, self).__init__(attributes, statically_defined) | |||
| def init(self): | |||
There was a problem hiding this comment.
something with this recent setup is causing kubernetes execution to fail:
in step_init
if self.attributes["gpu_vendor"].lower() not in ("amd", "nvidia"):
AttributeError: 'NoneType' object has no attribute 'lower'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not yet fully ready but putting out so people can get a general sense of the direction.