Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing a unified spec and sdk #1

Closed
wants to merge 7 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/workflows/build-typescript-sdk.yml
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,13 @@ jobs:
npm install
npm run build

- name: Archive test build
uses: actions/upload-artifact@v3
with:
name: pr-test-build
path: |
plexjs

- name: After SDK Build
if: steps.buildSDK.outcome == 'success'
run: |
Expand Down
9 changes: 5 additions & 4 deletions .github/workflows/test-oag-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,21 +40,22 @@ jobs:
- name: Build PMS SDK
id: buildPMS
run: |
cd sdk-ts
rm -rf plexjs/pms
java -jar openapi-generator-cli.jar generate -i api-specs/pms/pms-spec.yaml -g typescript-axios -o plexjs/pms --config sdk-resources/pms-config-test.yaml
java -jar openapi-generator-cli.jar generate -i ../pms/pms-spec.yaml -g typescript-axios -o plexjs/pms --config sdk-resources/pms-config-test.yaml

- name: Build PTV SDK
id: buildPTV
run: |
cd sdk-ts
rm -rf plexjs/plextv
java -jar openapi-generator-cli.jar generate -i api-specs/plextv/plextv-spec.yaml -g typescript-axios -o plexjs/plextv --config sdk-resources/plextv-config-test.yaml
java -jar openapi-generator-cli.jar generate -i ../plextv/plextv-spec.yaml -g typescript-axios -o plexjs/plextv --config sdk-resources/plextv-config-test.yaml

- name: Archive test build
uses: actions/upload-artifact@v3
with:
name: OAG-7.0.1-pr-test
path: |
plexjs
path: sdk-ts

- name: Run npm install and build Typescript SDK
id: buildSDK
Expand Down
14 changes: 6 additions & 8 deletions .github/workflows/validate-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,18 +48,16 @@ jobs:
rm -rf plexjs/plextv
java -jar openapi-generator-cli.jar generate -i ../plextv/plextv-spec.yaml -g typescript-axios -o plexjs/plextv --global-property skipFormModel=false --config sdk-resources/plextv-config.yaml

- name: After SDK Build
uses: actions/upload-artifact@v3
with:
name: PR-Build
path: sdk-ts

- name: Run npm install and build Typescript SDK
id: buildSDK
if: steps.buildPTV.outcome == 'success'
run: |
cd sdk-ts/plexjs
npm install
npm run build

- name: After SDK Build
if: steps.buildSDK.outcome == 'success'
uses: actions/upload-artifact@v3
with:
name: PR-Build-${{ github.ref }}
path: |
plexjs
2 changes: 1 addition & 1 deletion plextv/paths/pins.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
post:
tags:
- Plex.tv
- PlexTVAPI
summary: Get a Pin
operationId: getPin
description: Retrieve a Pin from Plex.tv for authentication flows
Expand Down
4 changes: 2 additions & 2 deletions plextv/plextv-spec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,8 @@ paths:
$ref: "./paths/geoip.yaml"
/home:
$ref: "./paths/home.yaml"
/pins:
$ref: "./paths/pins.yaml"
# /pins:
# $ref: "./paths/pins.yaml"
/pins/{pinID}:
$ref: "./paths/pins-id.yaml"
/resources:
Expand Down
6 changes: 6 additions & 0 deletions pms/pms-spec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,12 @@ paths:
/:/timeline:
$ref: "./paths/timeline.yaml"

/pins:
servers:
- url: https://plex.tv/api/v2
description: The full address of your Plex Server
$ref: "../plextv/paths/pins.yaml"

tags:
- name: Activities
description: |
Expand Down