🐛 On branch BUG/1608_glances-network-error #1646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to be committed: modified: src/components/Widgets/GlNetworkInterfaces.vue modified: src/components/Widgets/GlNetworkTraffic.vue bug ref: #1608 v4api ref: https://glances.readthedocs.io/en/latest/api.html#get-network v3api ref: https://github.com/nicolargo/glances/blob/support/glancesv3/docs/api.rst#get-network
✅ Deploy Preview for dashy-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
CrazyWolf13
approved these changes
Aug 7, 2024
|
I can look again later this week at the ip plugin.
I suspect it is a similar problem in that the fields returned have changed
names.
…On Wed, Aug 7, 2024, 07:03 Tobias ***@***.***> wrote:
Fixes #1608 <#1608> and #1594
<#1594> 🚀
—
Reply to this email directly, view it on GitHub
<#1646 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AX7BZ24S3HGHMR3UGWZB2G3ZQH5JRAVCNFSM6AAAAABLHN4U2KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZTGIYDKOJRHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
The glances gl-ip-address widget seems to work with no errors? Where is the version error message? |
Lissy93
approved these changes
Aug 17, 2024
|
I see this was approved a bit ago. Is there something else I need to do that I have not done? |
|
Yes, a merge was needed :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category:
BUGFIX
Overview
Glances Widgets for Network Traffic and Interfaces were not correctly displaying information provided from the api response.
Issue Number #1608
Code Quality Checklist (Please complete)