Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Update GlNetworkTraffic.vue glances api changes to v4 from v3 #1643

Closed
wants to merge 1 commit into from

Conversation

hockwill
Copy link
Contributor

@hockwill hockwill commented Jul 21, 2024

hockwill Quick hockwill /patch-2 → Lissy93/dashy Commits: 1 | Files Changed: 1 | Additions: 0 Label Unchecked Tasks Powered by Pull Request Badge

apiv3 ref:https://github.com/nicolargo/glances/blob/support/glancesv3/docs/api.rst#get-network

apiv4 ref:https://github.com/nicolargo/glances/blob/support/glancesv3/docs/api.rst#get-network

-fields seem to have name changes from _rx/_tx/cx to bytes

Category:

One of: Bugfix

Overview

Briefly outline your new changes...

Issue Number (if applicable) #1608

New Vars (if applicable)

If you've added any new build scripts, environmental variables, config file options, dependency or devDependency, please outline here

Screenshot (if applicable)

If you've introduced any significant UI changes, please include a screenshot

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • (If significant change) Bumps version in package.json

@hockwill hockwill requested a review from Lissy93 as a code owner July 21, 2024 19:34
Copy link

netlify bot commented Jul 21, 2024

Deploy Preview for dashy-dev ready!

Name Link
🔨 Latest commit ffc2c31
🔍 Latest deploy log https://app.netlify.com/sites/dashy-dev/deploys/669d62ceaf6f6a00087ecfc4
😎 Deploy Preview https://deploy-preview-1643--dashy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hockwill hockwill changed the title Update GlNetworkTraffic.vue glances api changes to v4 from v3 🐛 Update GlNetworkTraffic.vue glances api changes to v4 from v3 Jul 22, 2024
@hockwill hockwill closed this Jul 22, 2024
@hockwill hockwill deleted the patch-2 branch August 24, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant