Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix types compatibility with React 19 #5912

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Methuselah96
Copy link
Collaborator

Fixes #5911.

React 19 removes the JSX type from the global scope, so it now needs to be imported from React.

This causes some immediate issues for the users of react-select who are trying to use it with @types/react@19, since the Select types relies on the JSX.LibraryManagedAttributes type.

Note that this is technically a breaking change because it requires TypeScript users to have a version of @types/react after DefinitelyTyped/DefinitelyTyped#64464 shipped.

Copy link

changeset-bot bot commented Jun 4, 2024

🦋 Changeset detected

Latest commit: ed73fc2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
react-select Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codesandbox-ci bot commented Jun 4, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Types broken in React@19 & Next@15
1 participant