Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openjdk: unbundle freetype on macOS #191113

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

openjdk: unbundle freetype on macOS #191113

wants to merge 1 commit into from

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Sep 18, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Need to pass in --with-freetype* as --with-sysroot disables pkg-config.

@github-actions github-actions bot added the CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. label Sep 18, 2024
@cho-m cho-m removed the CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. label Sep 18, 2024
@cho-m
Copy link
Member Author

cho-m commented Sep 18, 2024

jdk-23-ga is out so may just rollup into other PR or wait until merged.

@github-actions github-actions bot added the CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. label Sep 19, 2024
@carlocab carlocab removed the CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants