Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openjdk 23 #182295

Merged
merged 2 commits into from
Sep 19, 2024
Merged

openjdk 23 #182295

merged 2 commits into from
Sep 19, 2024
+23 −18

Conversation

ZhongRuoyu
Copy link
Member

@ZhongRuoyu ZhongRuoyu commented Aug 24, 2024 •
edited
Loading

Testing the final release candidate 12 before Sequoia mass bottling eats up CI resources.

Update: The final release candidate (jdk-23+37), tested in #182295 (comment), is identical to the general-availability release (jdk-23-ga).

Footnotes

  1. https://openjdk.org/projects/jdk/23/ ↩

  2. https://mail.openjdk.org/pipermail/jdk-dev/2024-August/009341.html ↩

@ZhongRuoyu ZhongRuoyu added pre-release Artifact is pre-release prerelease-testing Pull request from upstream, testing a pre-release with homebrew dependencies labels Aug 24, 2024
@github-actions github-actions bot added the CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. label Aug 24, 2024
@ZhongRuoyu ZhongRuoyu changed the title openjdk 23 openjdk 23 (RC) Aug 24, 2024
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Aug 24, 2024
@ZhongRuoyu ZhongRuoyu added CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. labels Aug 24, 2024
@ZhongRuoyu ZhongRuoyu added the long dependent tests Set a long timeout for dependent testing label Aug 24, 2024
@ZhongRuoyu

This comment was marked as outdated.

Sign in to view
@calvinit
Copy link
Contributor

jdk-23-ga already released!

@ZhongRuoyu ZhongRuoyu changed the title openjdk 23 (RC) openjdk 23 Sep 18, 2024
@ZhongRuoyu ZhongRuoyu removed pre-release Artifact is pre-release prerelease-testing Pull request from upstream, testing a pre-release with homebrew dependencies labels Sep 18, 2024
@ZhongRuoyu ZhongRuoyu marked this pull request as ready for review September 18, 2024 03:12
@calvinit
Copy link
Contributor

Why is there no two checks of CI / macOS 15-x86_64 (pull_request) and CI / macOS 15-x86_64 (deps) (pull_request)? @ZhongRuoyu

@ZhongRuoyu
Copy link
Member Author

Why is there no two checks of CI / macOS 15-x86_64 (pull_request) and CI / macOS 15-x86_64 (deps) (pull_request)? @ZhongRuoyu

Because we haven't started to build bottles for x86_64 macOS 15 by default yet. Issues are being sorted out and the bottle will eventually be built. Before that, users get the macOS 14 bottle which should work too.

@ZhongRuoyu ZhongRuoyu mentioned this pull request Sep 19, 2024
Merged
6 tasks
@ZhongRuoyu
Copy link
Member Author

The final release is identical to the final release candidate tested earlier, so all problems seen in the latest run have been already covered in previous test (minus several HTTP 403 failures connecting to Maven, which seem to be transient as they work now):

scala fails because it doesn't seem to support JDK 23 yet. This will be handled by #191248.

opensearch and teku failures appear to be build-only issues with JDK 23 (specifically, with Javadoc and build-time checks respectively). Can look into this as a follow-up but the existing bottles should still work.

@ZhongRuoyu
Copy link
Member Author

ready to merge PR can be merged once CI is green after #191248.

@github-actions GitHub Actions
Copy link
Contributor

:shipit: @ZhongRuoyu has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Sep 19, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Sep 19, 2024
Merged via the queue into master with commit 217d336 Sep 19, 2024
15 checks passed
@BrewTestBot BrewTestBot deleted the openjdk-23 branch September 19, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlocab carlocab carlocab approved these changes

@github-actions GitHub Actions github-actions approved these changes

Assignees
No one assigned
Labels
automerge-skip `brew pr-automerge` will skip this pull request CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. long dependent tests Set a long timeout for dependent testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ZhongRuoyu @calvinit @carlocab @BrewTestBot