Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(customtoolnode): add return direct to custom tool #2594

Conversation

patrickreinan
Copy link
Contributor

Added return direct option to CustomTool node.

@HenryHengZJ
Copy link
Contributor

1 bug we have by returning direct is that, it still streams the output from LLM:
image

But if you close the chat window and open again, it will shows the output returned directly from custom tool:
image

@patrickreinan
Copy link
Contributor Author

@HenryHengZJ this image is different from version that I have pushed. I added a checkbox to turn return direct on.

I am using this version and I am not facing this issue. I will check with latest branch main version.

@patrickreinan
Copy link
Contributor Author

@HenryHengZJ I could reproduce the issue here. I will check what is happening and fix the issue.

@HenryHengZJ
Copy link
Contributor

HenryHengZJ commented Jun 12, 2024

@HenryHengZJ this image is different from version that I have pushed. I added a checkbox to turn return direct on.

I am using this version and I am not facing this issue. I will check with latest branch main version.

oh yeah I was hard-coding returnDirect to true in the code so

@patrickreinan
Copy link
Contributor Author

I got it. 😉

@patrickreinan
Copy link
Contributor Author

@HenryHengZJ I did some changes in my code. I figured out that when agent try to call a custom tool with return direct with invalid parameters, automatically a empty text was being returned in a JSON format. I think this was the cause the bug that you have mentioned.

@HenryHengZJ
Copy link
Contributor

hey @patrickreinan sorry for late response. I've added this PR that solve the issue: #3003, feel free to try it out and see if that works correctly. Closing this for now

@patrickreinan
Copy link
Contributor Author

😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants