Fix LAN and multi-player crash on empty map or game mode #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Workaround: when Map or GameMode is null, don't send broadcast message. |
|
Nightly build for this pull request:
|
SadPencil
force-pushed
the
fix-empty-fav-list
branch
from
179734f
to
ca44087
Compare
|
After investigating this issue again, it seems this is another eight-year-old bug. Hopefully this PR fixes it. Needs to be tested. |
|
When Map or GameMode is null, the client now sends "Unknown" as their names instead of crashing |
SadPencil
force-pushed
the
fix-empty-fav-list
branch
from
ca44087
to
f247455
Compare
SadPencil
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs to be tested.
Fixes #377
Reproduce the bug:
Create a LAN game
Select "Favorite Maps" in game mode
Wait for a few second
As no maps are selected the broadcast triggers a null reference exception
Or one can modify a game option to trigger a null reference exception