Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: route audio from CEF #1517

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

feat: route audio from CEF #1517

wants to merge 4 commits into from

Conversation

Julusian
Copy link
Member

@Julusian Julusian commented Jan 5, 2024

Inspired by/based upon a start made by nxtedition at https://github.com/nxtedition/casparcg

This needs a bit more testing to ensure it works smoothly and without glitches.
In particular, when audio starts/stops within the page, and when motion starts/stops

This also needs a sync test, to check that the audio is in sync and remains in sync with both video and audio pausing and resuming

@Julusian Julusian linked an issue Jan 5, 2024 that may be closed by this pull request
@qu1rk3y
Copy link

qu1rk3y commented Jun 5, 2024

Is there any progress on this feature?

@Julusian
Copy link
Member Author

Julusian commented Jun 8, 2024

@qu1rk3y I did this prototype implementation a while back because I was curious on how hard it would be, but haven't done as much testing as I think it needs before it can be merged.
So it has sat waiting for that testing to be done before it can progress.

If anyone wants to give it a try, there is a build based on top of the master branch at the time of writing at https://builds.julusian.dev/casparcg/casparcg-server-b52edd40855b659798c9b78643e66d1d8e6aebdc-windows.zip
Please report back if it works fine for you or if you had any issues, that will help with confidence to get this merged.

@Sidonai-1
Copy link

Sidonai-1 commented Jun 13, 2024

@qu1rk3y I did this prototype implementation a while back because I was curious on how hard it would be, but haven't done as much testing as I think it needs before it can be merged.
So it has sat waiting for that testing to be done before it can progress.

If anyone wants to give it a try, there is a build based on top of the master branch at the time of writing at https://builds.julusian.dev/casparcg/casparcg-server-b52edd40855b659798c9b78643e66d1d8e6aebdc-windows.zip
Please report back if it works fine for you or if you had any issues, that will help with confidence to get this merged.

I tried to test this but I was unable to run this server, it was complaining about an asio io_service. I don't know if the error comes from that or the diagnostics exception.

IMG20240613132014.jpg

This happens in b52edd4 as well as latest master build e4e9ed2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[HTML Producer] Audio not routed to consumers
3 participants