builtins/array: impl constructor as ts

move to ts from internal constructor hack used previously

test262: 41.52% (+0.04) | 🧪 48414 | 🤠 20101 (+21) | ❌ 6460 (-12) | 💀 15596 (-5) | 🏗️ 64 | 💥 301 | ⏰ 27 (-4) | 📝 5865

compiler/builtins/array.ts

@@ -1,5 +1,37 @@
 import type {} from './porffor.d.ts';
 
+export const Array = function (...args: any[]): any[] {
+  const argsLen: number = args.length;
+  if (argsLen == 0) {
+    // 0 args, new 0 length array
+    const out: any[] = Porffor.allocate();
+    return out;
+  }
+
+  if (argsLen == 1) {
+    // 1 arg, length (number) or first element (non-number)
+    const arg: any = args[0];
+    if (Porffor.rawType(arg) == Porffor.TYPES.number) {
+      // number so use as length
+      const n: number = args[0];
+      if (Porffor.fastOr(
+        n < 0, // negative
+        n > 4294967295, // over 2**32 - 1
+        !Number.isInteger(n) // non-integer/non-finite
+      )) throw new RangeError('Invalid array length');
+
+      const out: any[] = Porffor.allocate();
+      out.length = arg;
+      return out;
+    }
+
+    // not number, leave to fallthrough as same as >1
+  }
+
+  // >1 arg, just return args array
+  return args;
+};
+
 export const __Array_isArray = (x: unknown): boolean =>
   Porffor.rawType(x) == Porffor.TYPES.array;
 

compiler/builtins/object.ts

@@ -1,8 +1,6 @@
 import type {} from './porffor.d.ts';
 
 export const Object = function (value: any): object {
-  new.target; // trick compiler into allowing as constructor
-
   if (value == null) {
     // if nullish, return new empty object
     const obj: object = Porffor.allocate();

compiler/codegen.js

@@ -6223,38 +6223,6 @@ const generateCode = (scope, decl) => {
 };
 
 const internalConstrs = {
-  Array: {
-    generate: (scope, decl, global, name) => {
-      // new Array(i0, i1, ...)
-      if (decl.arguments.length > 1) return generateArray(scope, {
-        elements: decl.arguments
-      }, global, name);
-
-      // new Array(n)
-      const [ out, pointer ] = makeArray(scope, {
-        rawElements: new Array(0)
-      }, global, name, true, undefined, true, true);
-
-      const arg = decl.arguments[0] ?? DEFAULT_VALUE();
-
-      // todo: check in wasm instead of here
-      const literalValue = arg.value ?? 0;
-      if (literalValue < 0 || !Number.isFinite(literalValue) || literalValue > 4294967295) return internalThrow(scope, 'RangeError', 'Invalid array length', true);
-
-      return [
-        ...out,
-        ...generate(scope, arg, global, name),
-        Opcodes.i32_to_u,
-        [ Opcodes.i32_store, Math.log2(ValtypeSize.i32) - 1, 0 ],
-
-        ...pointer,
-        Opcodes.i32_from_u
-      ];
-    },
-    type: TYPES.array,
-    length: 1
-  },
-
   __Array_of: {
     // this is not a constructor but best fits internal structure here
     generate: (scope, decl, global, name) => {

package.json

@@ -1,7 +1,7 @@
 {
   "name": "porffor",
   "description": "a basic experimental wip aot optimizing js -> wasm engine/compiler/runtime in js",
-  "version": "0.40.3+5f310db4d",
+  "version": "0.40.4+cc1f25444",
   "author": "CanadaHonk",
   "license": "MIT",
   "scripts": {},

runner/index.js

@@ -1,6 +1,6 @@
 #!/usr/bin/env node
 import fs from 'node:fs';
-globalThis.version = '0.40.3+5f310db4d';
+globalThis.version = '0.40.4+cc1f25444';
 
 // deno compat
 if (typeof process === 'undefined' && typeof Deno !== 'undefined') {