Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning NCQ Code #38

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

felipejrabelo
Copy link

DO NOT NEED TO ACCEPT THIS PULL REQUEST

NCQ might have been changed locally in the author's computer (out of sync).

Just started doing some code cleaning:

  • Removed a duplicated IF statement to avoid extra comparisons inside a loop.

  • Started to use string interpolation instead concatenation.

  • Add constants to avoid string repetitions all over the code.

All tests passed after changes !

I have notice that by starting two process of NCQ the temporary folders (tmp1, tmp2,...) can be replaced or erased by one process or another cause the code do not check if the folder already exists.

@Brittany-Reid
Copy link
Owner

Hi Felipe,

Thanks for the pull request.

I will give this a proper check after our session (I don't want to make any changes until the sessions are complete).

I have notice that by starting two process of NCQ the temporary folders (tmp1, tmp2,...) can be replaced or erased by one process or another cause the code do not check if the folder already exists.

Yep, for the running of the sessions we need to keep a user's code for research purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants