ExposeFeedRangeAsClassType #37444
Open
ExposeFeedRangeAsClassType #37444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run python - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| def _to_feed_range_internal(self) -> 'FeedRangeInternal': | ||
| pass | ||
|
|
||
| def _to_base64_encoded_string(self) -> str: |
There was a problem hiding this comment.
Should the result be cached - to avoid having to do this multiple times?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second PR for exposingFeedRange in change feed query. In PR #36930, we have exposed feedRange as a
strtype, but it comes with perf penalty - for eachread_feed_rangesresponse, we would have to always do the base64 encoding, and for eachquery_items_change_feedusingfeed_rangewe have to decode the string.In this PR, we will expose a FeedRange class type