Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline V3 #37428

Open
wants to merge 173 commits into
base: main
Choose a base branch
from
Open

Pipeline V3 #37428

wants to merge 173 commits into from

Conversation

scbedd
Copy link
Member

@scbedd scbedd commented Sep 17, 2024

This PR:

  • Updates PullRequests to utilize git to run CI only packages that were changed
    • Packages that have been changed may optionally include other packages for sparse validation. For instance azure-core configures an additional 15 or so packages that must be brought in for sparse validation. This is configured solely in get_package_properties.py.
  • Affected packages are now batched, so even if a PR touches 50+ packages, we will simply expand the test matrix by limiting each test run to a max of 8 packages (arbitrary limit). We just...add more test runs. Analyze will still have an issue with this many packages, I will likely multiplex that in follow-up PRs as well.
    • In the above case, when additional validation packages are pulled in due to a large number of directly affected packages, we will also sparsely include those validation packages into the test matrix. ("sparsely" translating to "on a single platform and python combination, we don't really care which")

scbedd and others added 30 commits July 19, 2024 15:20
…y close to being ready to go. got a lot of simplifying to work through
sdk/pr.yml Outdated
@@ -0,0 +1,23 @@
trigger:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will want to update these triggers before merging. Given we plan to name the pipeline "python - pullrequest" I would also suggest renaming this to pullrequest.yml.

Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments/questions to look at before merging and a few others that I tagged with follow-up that can come at a later time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🔬 Dev in PR
Development

Successfully merging this pull request may close these issues.

4 participants