Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added caching of decision request response #264

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

HenningNormann
Copy link
Contributor

Description

The udir performance test case triggers 65 decision requests. With caching of the decision request response the number of requests is reduced to 4.

Related Issue(s)

  • #{issue number}

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@HenningNormann HenningNormann changed the title Added caching of decision response Added caching of decision request response Mar 2, 2023
Copy link
Member

@jonkjetiloye jonkjetiloye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PEP has no context of the state of an instance. So caching the result based on the request alone is not sufficient and can lead to false positives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants