Skip to content
This repository has been archived by the owner on Jan 6, 2022. It is now read-only.

gulpfile: Refine build pipeline #277

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from
Draft

gulpfile: Refine build pipeline #277

wants to merge 13 commits into from

Conversation

wei2912
Copy link
Member

@wei2912 wei2912 commented Aug 5, 2021

This PR makes a couple of refinements to gulpfile.js and related build pipelines, such as autoprefixer, CSS compression, proper source maps, production zipping and reloading based on changes to config files.

@wei2912 wei2912 added bug Something isn't working enhancement New feature or request labels Aug 5, 2021
@wei2912 wei2912 self-assigned this Aug 5, 2021
@wei2912 wei2912 marked this pull request as draft August 5, 2021 05:52
@wei2912 wei2912 requested a review from bnjmnt4n August 5, 2021 05:53
@wei2912
Copy link
Member Author

wei2912 commented Aug 5, 2021

Quite strangely, the source map for main.css does not work. No idea why :'(

@wei2912 wei2912 added the help wanted Extra attention is needed label Aug 5, 2021
@wei2912
Copy link
Member Author

wei2912 commented Aug 28, 2021

Ideally this should be worked on after #288 is settled.

@wei2912
Copy link
Member Author

wei2912 commented Sep 11, 2021

Rebased onto ec37f62.

@wei2912
Copy link
Member Author

wei2912 commented Sep 14, 2021

From this commit, it appears that JS and CSS compression work fine and the source maps are generated. However, my browser claims that these source maps link to nowhere, so I'm not sure how to proceed... passing this on to @bnjmnt4n for review.

@wei2912
Copy link
Member Author

wei2912 commented Sep 14, 2021

After investigating further, it seems like sources in main.css.map is set rather bizarrely:

"sources":["../../node_modules/tailwindcss/base.css","%3Cinput%20css%20K4lNQA%3E","%3Cinput%20css%20WkKA6a%3E","<no source>","../../node_modules/tailwindcss/components.css","../../node_modules/tailwindcss/utilities.css","ghost/header.css","ghost/content.css","ghost/errors.css","ghost/footer.css","main.css"

I have no idea where the "%3input..." stuff came from, and why there's a "<no source>"...

@Hackin7
Copy link
Contributor

Hackin7 commented Oct 30, 2021

Sorry but I'm not quite sure what needs to be done here

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants