Skip to content
This repository has been archived by the owner on Jan 6, 2022. It is now read-only.

Error: Migrate CSS to Tailwind #249

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Error: Migrate CSS to Tailwind #249

wants to merge 1 commit into from

Conversation

wei2912
Copy link
Member

@wei2912 wei2912 commented Jun 7, 2021

This PR removes assets/css/ghost/errors.css and replaces the classes with somewhat equivalent CSS styles.

Tbh I haven't tested the theme error stack as I have no idea how to trigger that error.

@wei2912 wei2912 added the enhancement New feature or request label Jun 7, 2021
@wei2912 wei2912 requested review from a team, bnjmnt4n and partysnax and removed request for a team June 7, 2021 10:55
@wei2912 wei2912 self-assigned this Jun 7, 2021
Copy link
Contributor

@partysnax partysnax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can view the error message by triggering error 404, such as visiting any page that doesn't exist on your local instance eg. localhost:2368/abcd/

The original error screen for reference:
2021-06-13_17h05_49

I feel that to best match the original design in error.hbs :

  • In line 3 under the section tag, the classes content-center can be removed (redundant) and prose should be removed (adds unnecessary margins between each line of text)
  • Line 4: Give the statusCode the class text-6xl
  • Line 5: Give the message the classes text-gray-400 text-xl

These are just suggestions, feel free to fine tune them

@wei2912
Copy link
Member Author

wei2912 commented Jun 26, 2021

@partysnax Thanks for the review! I was looking to use prose to standardise the formatting across all pages, but I think it would require some special set up to prevent the h1 styles from being overridden. Been looking into that since 2 weeks ago...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants