Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add annotation to configure ingress weight #55

Open
Aluxima opened this issue Sep 27, 2021 · 2 comments
Open

Add annotation to configure ingress weight #55

Aluxima opened this issue Sep 27, 2021 · 2 comments

Comments

@Aluxima
Copy link
Contributor

Aluxima commented Sep 27, 2021

Adding an yggdrasil.uswitch.com/weight annotation would be useful to configure lbEndpoint load_balancing_weight for each ingress.
Omitting it empty would not change the current behavior.

In addition to that, giving a weight of 0 could be a special case to remove an ingress from an Envoy cluster.

@Joseph-Irving
Copy link
Contributor

+1 to this idea, we've discussed in the past having a way to remove an ingress would be nice, as just deleting the ingress causes momentary errors as envoy will still send requests there for a little while.

@Solvik
Copy link

Solvik commented Jul 5, 2024

and here's the MR #83 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants