Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slab::drain() should return the indices of the elements #136

Open
tomaka opened this issue May 31, 2023 · 1 comment
Open

Slab::drain() should return the indices of the elements #136

tomaka opened this issue May 31, 2023 · 1 comment

Comments

@tomaka
Copy link
Contributor

tomaka commented May 31, 2023

When calling into_iter(), the Slab returns an iterator that yields (usize, T).

But when calling drain(), only Ts are returned, and the indices of the elements are lost.

This is an inconsistency in the API, but also knowing these indices is necessary for my use case.
I'm currently bypassing this with mem::replace(&mut slab, Slab::new()).into_iter().

@Darksonn
Copy link
Contributor

That makes sense to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants