Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max Width Restriction? #577

Open
AlJohri opened this issue Jul 28, 2024 · 1 comment
Open

Max Width Restriction? #577

AlJohri opened this issue Jul 28, 2024 · 1 comment
Labels
S-bug Severity: bug

Comments

@AlJohri
Copy link

AlJohri commented Jul 28, 2024

What crate(s) in this repo are involved in the problem?

tokio-console

What is the issue?

The issue is that there appears to be some maximum width restriction preventing me from zooming out far enough to see the full text in the rightmost column.

Screenshot 2024-07-28 at 8 54 00 AM

How can the bug be reproduced?

Screen.Recording.2024-07-28.at.7.50.39.AM.mov

You can reproduce the bug by pressing CMD and - repeatedly. A few times the width of the tokio-console will adjust properly. But after pressing it enough times, it will stop adjusting and stay at some maximum width.

Logs, error output, etc

No response

Versions

❯ cargo tree | grep console-                            
│   ├── console-subscriber v0.3.0
│   │   ├── console-api v0.7.0
├── console-subscriber v0.3.0 (*)
├── console-subscriber v0.3.0 (*)

Possible solution

No response

Additional context

No response

Would you like to work on fixing this bug?

yes

@AlJohri AlJohri added the S-bug Severity: bug label Jul 28, 2024
@hds
Copy link
Collaborator

hds commented Jul 29, 2024

After talking to the Ratatui devs, it looks like this is a limitation in Ratatui (and perhaps also in the underlying terminal library). The dimensions (height and width) are stored as u16 and that effectively restricts the total area that is rendered to a u16 as well.

This isn't intentional, but it isn't clear what the correct solution is. I didn't manage to find an issue on the Ratatui project, but I was given this comment as a reference: ratatui/ratatui#174 (comment)

It was suggested that providing some sort of notification when the terminal is larger than the limit, but I'm not entirely sure how to achieve that right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-bug Severity: bug
Projects
None yet
Development

No branches or pull requests

2 participants