Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SAML: improvements to admin page #426

Open
stsewd opened this issue Jul 18, 2024 · 0 comments
Open

SAML: improvements to admin page #426

stsewd opened this issue Jul 18, 2024 · 0 comments
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code
Milestone
Dashboard minor bugs

Comments

@stsewd
Copy link
Member

stsewd commented Jul 18, 2024 •
edited by agjohnson
Loading

This is the template at https://github.com/readthedocs/ext-theme/blob/main/readthedocsext/theme/templates/organizations/settings/saml.html

Some issues:

  • Display issues on spacing and positioning
  • Heading copy doesn't match what users are using the information for -- "details" vs "configuration". See the previous PR for comments here.
  • Multiple {{ form | crispy }} -- all other views only display a single form so the rendered in predictable
  • Drop magic links for proper team invites

Ref #348 (comment)
@agjohnson agjohnson added Improvement Minor improvement to code Accepted Accepted issue on our roadmap labels Jul 18, 2024
@agjohnson agjohnson added this to the Dashboard minor bugs milestone Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code
Projects
None yet
Milestone
Dashboard minor bugs
Development

No branches or pull requests
2 participants
@agjohnson @stsewd