Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New element in a table is placed in the wrong place #361

Closed
Namnamseo opened this issue Jun 26, 2024 · 0 comments · Fixed by #366
Closed

New element in a table is placed in the wrong place #361

Namnamseo opened this issue Jun 26, 2024 · 0 comments · Fixed by #366

Comments

@Namnamseo
Copy link

Hi, nice work here. Thank you for the project.

I have a bug report to file.

x = tomlkit.parse('''
[root1.root2]
  value = 1
[root1.root2.a.b.c]
  value = 2
[WALRUS]
  goo = "gjob"
[root1.root2.x]
  value = 4
''')
x['root1']['root2']['a'].add('tmp', 'hi')
print(tomlkit.dumps(x))

Expected (amongst other formatting possibilities):

[root1.root2]
  value = 1
[root1.root2.a]
tmp = "hi"
[root1.root2.a.b.c]
  value = 2
[WALRUS]
  goo = "gjob"
[root1.root2.x]
  value = 4

But the code rather prints:

[root1.root2]
  value = 1
[root1.root2.a]
[root1.root2.a.b.c]
  value = 2
tmp = "hi"
[WALRUS]
  goo = "gjob"
[root1.root2.x]
  value = 4

This TOML code places tmp = "hi" under a.b.c, not a (as the Python code said).

Another instance of the bug is:

x = tomlkit.parse('''
[root1.root2.a.b.c]
  value = 2
[WALRUS]
  goo = "gjob"
[root1.root2.x]
  value = 4
''')
x['root1']['root2']['a'].add('tmp', 'hi')
print(tomlkit.dumps(x))

(NOTE: the code is almost the same. The only difference is that [root1.root2] is gone in the TOML.)

In this case, the output does not change with .add(), nor even a direct setitem:

>>> x['root1']['root2']['a']['tmp'] = 'hi'
>>> x['root1']['root2']['a']
{'b': {'c': {'value': 2}}}

Maybe the update is happening on some kind of proxy object, which interacts badly with the original object, I don't know.

Maybe there's a bug in parsing out-of-order sections, cc. #196 #261?

@frostming frostming linked a pull request Jul 10, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant