Refactor integration tests to be table-driven #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
zbuchheit
commented
Sep 18, 2024
zbuchheit
commented
- Refactor integration tests to be table-drive and all check for a diff-less preview
- Rename some tests to accurately reflect their resources
- Make resources in tests consistently have hyphenated pulumi names
Add additional arguments to the site-settings-ts test for a more robust test. Also check for a spurious diff and expect no changes.
The pulumi names of the resources were inconsistently hyphenated and underscored. Changing these resources to all be hyphenated. Also, rename all the wlan ssid to be named after their test.
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
zbuchheit
force-pushed
the
zbuchheit/integration-tests-14119080
branch
from
4abf50f
to
c17caf0
Compare
Rename the site-wlan-ts test and site-wlan-isolation-ts test to reflect the resources inside. They are not org wlans.
The new version of providertest requires you to include t when you call pulumitest operations.
zbuchheit
force-pushed
the
zbuchheit/integration-tests-14119080
branch
from
c17caf0
to
93f9c48
Compare
|
I missed some linting, that's why the force push |
mikhailshilkov
approved these changes
Sep 19, 2024
|
This PR has been shipped in release v0.0.24. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.