Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws.redshiftserverless.Workgroup config_parameters not resolved correctly #4405

Open
Ownmarc opened this issue Aug 26, 2024 · 1 comment
Open
Labels
awaiting-upstream The issue cannot be resolved without action in another repository (may be owned by Pulumi). kind/bug Some behavior is incorrect or out of spec

Comments

@Ownmarc
Copy link

Ownmarc commented Aug 26, 2024

Describe what happened

Workgroup with a subset of the config_parameters will cause Pulumi up to try to update the workgroup even if nothing has changed. It will then get an error because nothing changed.

Passing all the default config parameters will not cause this issue.

Sample program

This will cause an error the second time you deploy the stack if nothing else changed on the workgroup config_parameters :

redshiftserverless_namespace = aws.redshiftserverless.Namespace(
    "redshiftserverless-namespace",
    namespace_name="redshiftserverless-namespace",
    admin_username="admin",
    admin_user_password="Whatever1",
    db_name="dev",
)

redshiftserverless_workgroup = aws.redshiftserverless.Workgroup(
    "redshiftserverless-workgroup",
    workgroup_name="redshiftserverless-workgroup),
    base_capacity=8,
    config_parameters=[
        {"parameterKey": "enable_case_sensitive_identifier", "parameterValue": "true"},
    ],
    enhanced_vpc_routing=False,
    namespace_name=redshiftserverless_namespace.namespace_name,
)

This works fine :

redshiftserverless_namespace = aws.redshiftserverless.Namespace(
    "redshiftserverless-namespace",
    namespace_name="redshiftserverless-namespace",
    admin_username="admin",
    admin_user_password="Whatever1",
    db_name="dev",
)

redshiftserverless_workgroup = aws.redshiftserverless.Workgroup(
    "redshiftserverless-workgroup",
    workgroup_name="redshiftserverless-workgroup),
    base_capacity=8,
    config_parameters=[
        {"parameterKey": "auto_mv", "parameterValue": "true"},
        {"parameterKey": "datestyle", "parameterValue": "ISO, MDY"},
        {"parameterKey": "enable_case_sensitive_identifier", "parameterValue": "true"},
        {"parameterKey": "enable_user_activity_logging", "parameterValue": "true"},
        {"parameterKey": "query_group", "parameterValue": "default"},
        {"parameterKey": "require_ssl", "parameterValue": "false"},
        {"parameterKey": "search_path", "parameterValue": "$user, public"},
        {"parameterKey": "use_fips_ssl", "parameterValue": "false"},
        {"parameterKey": "max_query_execution_time", "parameterValue": "14400"},
    ],
    enhanced_vpc_routing=False,
    namespace_name=redshiftserverless_namespace.namespace_name,
)

Log output

I0826 13:29:23.073314   17180 provider_plugin.go:1871] provider received rpc error `Unknown`: `updating urn:pulumi:local::my-stack::aws:redshiftserverless/workgroup:Workgroup::redshiftserverless-workgroup: 1 error occurred:
	* updating Redshift Serverless Workgroup (redshiftserverless-workgroup): ValidationException: You didn't specify any changes to the configuration parameters.

Affected Resource(s)

No response

Output of pulumi about

CLI
Version 3.129.0
Go Version go1.22.6
Go Compiler gc

Plugins
KIND NAME VERSION
resource aws 6.49.1
resource awsx 2.14.0
resource docker 4.5.5
language python unknown

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@Ownmarc Ownmarc added kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team labels Aug 26, 2024
@corymhall
Copy link
Contributor

@Ownmarc thanks for reporting the issue! It looks like this is due to an upstream bug hashicorp/terraform-provider-aws#33899. A comment on a related PR seems to summarize what you are seeing.

...the moment you decide to specify any config parameters, you need to provide the values for ALL of the advanced controls over database...

@corymhall corymhall added awaiting-upstream The issue cannot be resolved without action in another repository (may be owned by Pulumi). and removed needs-triage Needs attention from the triage team labels Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-upstream The issue cannot be resolved without action in another repository (may be owned by Pulumi). kind/bug Some behavior is incorrect or out of spec
Projects
None yet
Development

No branches or pull requests

2 participants