Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated Gamelift MatchMaking resources #4375

Open
t0yv0 opened this issue Aug 16, 2024 · 1 comment
Open

Remove deprecated Gamelift MatchMaking resources #4375

t0yv0 opened this issue Aug 16, 2024 · 1 comment
Labels
impact/breaking Fixing this issue will require a breaking change kind/task Work that's part of an ongoing epic

Comments

@t0yv0
Copy link
Member

t0yv0 commented Aug 16, 2024

Remove deprecated Gamelift MatchMaking resources.

This is a reminder for the next major release of pulumi-aws.

These got deprecated in: #4257

@t0yv0 t0yv0 added impact/breaking Fixing this issue will require a breaking change kind/task Work that's part of an ongoing epic labels Aug 16, 2024
t0yv0 added a commit that referenced this issue Aug 21, 2024
Upgrade upstream to
[5.63.0](https://github.com/hashicorp/terraform-provider-aws/releases/tag/v5.63.0)

Fixes #4373
Fixes #4372
Fixes #3713
Fixes #4369

There are some changes to patches:

- #4369 is removed as it is
part of upstream now

- #3713 is removed as there
was no clean conflict resolution; this patch is under test so if test
suite passes the removal is safe

- #2746 patch is edited to
remove rds/security_group resource code that got removed upstream but
was preserved in patches. This code appears to be dead / unused code but
continues to generate conflicts

- added a patch for gamelift.Matchmaking* resources; these are
[deprecated](#4375) but
remain supported until the next major release. Upstream moved gamelift
to Go SDK v2 so the patch is needed to preserve the Go SDK v1 code for
these resources without re-coding them.

- added a patch to fix tags for new PF-based resources; this can go away
once we land #4151

---------

Co-authored-by: Florian Stadler <[email protected]>
@t0yv0
Copy link
Member Author

t0yv0 commented Sep 4, 2024

Before going forward, confirm no paying customers affected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/breaking Fixing this issue will require a breaking change kind/task Work that's part of an ongoing epic
Projects
None yet
Development

No branches or pull requests

1 participant