Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User control panel > Add user issues with validation errors #6197

Open
stevepiercy opened this issue Jul 25, 2024 · 6 comments
Open

User control panel > Add user issues with validation errors #6197

stevepiercy opened this issue Jul 25, 2024 · 6 comments

Comments

@stevepiercy
Copy link
Collaborator

Describe the bug

When adding a user in the User control panel, and when any error occurs, the submit button doubles up.

Additionally one must scroll the panel to view any error messages, and it is not obvious that there may be a problem.

To Reproduce

  1. Login as admin/admin on https://demo.plone.org/
  2. Go to the User control panel https://demo.plone.org/controlpanel/users
  3. Click + to add a new user.
  4. Fill in details but leave the password field blank.
  5. Submit the form.
  6. Scroll to the top to observe the following screenshot.
    Screenshot 2024-07-25 at 1 43 31 PM

Expected behavior
Show the errors in some manner that does not require the user to scroll. Auto-scrolling would be OK, but might not be the best option.

Software

plone6-demo 1.0.0
Volto 17.16.0
Plone 6.0.11
plone.restapi 9.6.1
CMF 3.5
Zope 5.9
Python 3.11.9 (main, May 14 2024, 08:32:26) [GCC 10.2.1 20210110]
PIL 9.5.0 (Pillow)

Add-ons

@plone/volto-slate 17.16.0
volto-subblocks 2.0.0
volto-form-block 3.8.3
@eeacms/volto-accordion-block 10.4.6
@kitconcept/volto-button-block 2.3.1
@kitconcept/volto-heading-block 2.4.0
@kitconcept/volto-highlight-block 3.0.1
@kitconcept/volto-introduction-block 1.0.0
@kitconcept/volto-separator-block 4.1.1
@kitconcept/volto-slider-block 6.3.1
@kitconcept/volto-light-theme 3.3.1
volto-demo 0.1.0
@barelysomethin
Copy link

hi @stevepiercy , i went through the volto repo but can't exactly the find the file which should contain this form field and code for control panel in general. can i get some guidance or any advice in general to navigate through the codebase efficiently.

@stevepiercy
Copy link
Collaborator Author

@barelysomethin I don't know.

Also please read and follow First-time contributors, especially Things not to do, Contributing to Plone, and Contributing to Volto.

@barelysomethin
Copy link

alright, thanks.

@wesleybl
Copy link
Member

wesleybl commented Aug 2, 2024

@Srihari2222
Copy link

Srihari2222 commented Aug 22, 2024

@stevepiercy yeah, it is not obvious. I have a idea of adding toast or alert so that the error can display right after submitting form without scrolling to top. Can you assign to me?

@stevepiercy
Copy link
Collaborator Author

@Srihari2222 no, we don't assign issues, but you can claim it for yourself. See First-time contributors, especially Item 1 in Things not to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants