Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change SearchView behaviour to set as a heading #4452

Open
10 tasks
Aitorbp opened this issue Aug 13, 2024 · 0 comments
Open
10 tasks

Change SearchView behaviour to set as a heading #4452

Aitorbp opened this issue Aug 13, 2024 · 0 comments

Comments

@Aitorbp
Copy link
Collaborator

Aitorbp commented Aug 13, 2024

In this accessibility issue #4362 it was reported that the Spaces title in the toolbar should work as a heading.

The problem is that this title is part of the SearchView, so when clicking on it (title + search icon) the search element opens, so that this title is not working as a heading but as a SearchView.
Therefore, an appropriate solution could be to separate the title element from the icon, in this way the title could work as a heading (it would not have a clickable option) and the icon as the searchview that would be the one to open the search element.

Looking at other apps, this is how they behave:

Accessibility settings android system:
In this case the title and the icon are separated. The first one has no functionality, while the second one opens the search element.
The title is not set as heading.

accessibility_settings_android_system

Drive:
In drive the behavior is different: You can make a selection in the whole toolbar and the talkback says: Search in Brive editbox. Afterwards you can access each element separately. In neither case do I name these elements as headings.

Captura de pantalla 2024-08-13 a las 10 52 29

My proposal would be to not put the title of the SearchView as heading and separate the title element from the icon. Open to discussion. It would be necessary to investigate if this is possible to do, since in the current application there are two toolbars coexisting.

TASKS

  • Research (if needed)
  • Create branch feature/feature_name
  • Development tasks
    • Implement whatever
    • ...
    • Implement unit tests (if needed)
  • Code review and apply changes requested
  • Design test plan
  • QA
  • Merge branch feature/feature_name into master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant