Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop populating severity text and instead auto-deduct it from severity number #2002

Open
cijothomas opened this issue Aug 8, 2024 · 4 comments
Assignees

Comments

@cijothomas
Copy link
Member

Mentioned here : https://github.com/open-telemetry/opentelemetry-rust/pull/1997/files#r1707954979
I wonder if should even remove SeverityText from LogRecord itself to reduce the size of LogRecord. I am not aware of any use case where user puts severity number and different text, so exporters can simply derive SeverityText from the numbered field to save perf.

@cijothomas cijothomas added this to the Logging Bridge API Stable milestone Aug 8, 2024
@cijothomas
Copy link
Member Author

@lalitb Please share your thoughts.

@lalitb
Copy link
Member

lalitb commented Aug 8, 2024

Agree on this. If we are always going to populate the textual representation of SeverityNumber here, there is no point of populating it in SDK. Let the exporter decide if they need it.

@lalitb
Copy link
Member

lalitb commented Aug 8, 2024

@lalitb
Copy link
Member

lalitb commented Aug 13, 2024

Discussion in community meeting

  • Having getters for LogRecord, and make existing fields to private.
  • Remove severity_text from LogRecord.

@lalitb lalitb self-assigned this Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants