Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OneLogin OIDC post_logout_redirect_uri issue #140

Open
kitebuggy opened this issue Jan 19, 2023 · 3 comments
Open

OneLogin OIDC post_logout_redirect_uri issue #140

kitebuggy opened this issue Jan 19, 2023 · 3 comments

Comments

@kitebuggy
Copy link

OneLogin requires the encoded id_token for the post_logout_redirect to work. I cannot see any way of obtaining that value from either Devise or Omniauth to easily monkey-patch the logout URI to include this to make this feature work.

Any suggestions? Thanks in advance!

@CSDUMMI
Copy link
Contributor

CSDUMMI commented Mar 1, 2023

When using keycloak the id_token_hint must be provided to directly redirect to the post_logout_uri without a confirmation dialog. I implemented a patch to this gem that successfully skipped this confirmation dialog.

I am hesitant to create a PR for this though, as I don' know whether other IdPs use the id_token_hint.

If this works for you, I'll consider making a PR to enable sending the access token as id_token_hint through an option.

@kitebuggy
Copy link
Author

Thanks, this is the info I needed. I'll comment directly on the patch for another matter, but this is a great insight, thank you!

@kitebuggy
Copy link
Author

This is perfect, thanks for submitting the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants