Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled debug testing for addons #398

Open
mhdawson opened this issue May 14, 2020 · 5 comments
Open

Enabled debug testing for addons #398

mhdawson opened this issue May 14, 2020 · 5 comments
Assignees
Milestone

Comments

@mhdawson
Copy link
Member

We should look at enabled testing of addons under debug in core.

@mhdawson mhdawson added this to the Milestone 11 milestone May 14, 2020
@mhdawson mhdawson self-assigned this May 14, 2020
@gabrielschulhof
Copy link
Collaborator

@mhdawson can we add a field to our top-level CI job that would cause it to append --debug to the npm test command line that runs our tests?

@mhdawson
Copy link
Member Author

mhdawson commented Jul 2, 2020

@gabrielschulhof do you mean an option when you run the job which can add the --debug or not? That might work, although I think in many cases we'd want Node.js to be compiled in debug which will be a challenge since right now we use the existing nightly builds instead of building Node.js

@mhdawson
Copy link
Member Author

mhdawson commented Jul 6, 2020

I think there is also this issue for adding debug testing in core. nodejs/build#1854

@mhdawson
Copy link
Member Author

mhdawson commented Jul 6, 2020

Next steps

@KevinEady
Copy link
Contributor

Found issue in node-addon-api: nodejs/node-addon-api#1511

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

3 participants