-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is it make sense for Node.js team to enable codespaces #1071
Comments
I think this would be a good idea if Github gently donated the cloud resources. I'm also not sure codespaces can actually build node.. |
Codespaces aren't available to the Node.js organization yet, but we can definitely have the conversation before. @mcollina You can do anything in them, they are ubuntu vms with root access. |
I mean I'm unsure how long it would take to build Node.js in there without some kind of compilation cache. |
it took 46 minutes the last time i tested it. |
That being said i would be 110% for a project sponsored compilation cache. Perhaps we could use electron's. |
They can. I've done it many times before. With a codespace, it's possible to set it up with a default configuration and custom .dotfiles so that ccache can be made available. That's not going to speed up a fresh build, of course, but a codespace (once created) can be persisted for a while so that subsequent builds are faster. |
hi sorry going through my notifications now and just catching this. I've built Node.js on every single machine size (I assume this likely surprises nobody). Codespaces can indeed build Node.js, but machine size really matters - you basically want to go as high as you can. I did a side-by-side comparison back when it was still VS Codespaces (the infra is largely the same from what I understand) on Basic vs. Premium. Basic crashed before the compile completed, after about 2 hours. Premium (8 cores) took about 20-25 minutes. The Normal (4 core) machines that Codespaces defaulted to until they added the ability to switch between sizes took about 40-45 minutes IIRC, which matches the time that @devsnek pointed out. Pre-building a Docker image would likely help quite a bit, which aligns with nodejs/node#39672 pretty nicely. Dropping in a |
AFAIK this is pretty tied to Azure-based infrastructure. Happy to internally advocate for donating that infrastructure to the project if we do go down this path. |
That would be indeed a really good stack/progress. |
Context: https://docs.github.com/en/codespaces/managing-codespaces-for-your-organization/enabling-codespaces-for-your-organization#configuring-which-users-in-your-organization-can-use-codespaces
The text was updated successfully, but these errors were encountered: