Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use calendly design and layout #6321

Open
19 of 20 tasks
Tracked by #6313
GretaD opened this issue Sep 4, 2024 · 3 comments · May be fixed by #6322
Open
19 of 20 tasks
Tracked by #6313

Use calendly design and layout #6321

GretaD opened this issue Sep 4, 2024 · 3 comments · May be fixed by #6322
Assignees
Labels
3. to review Waiting for reviews

Comments

@GretaD
Copy link
Contributor

GretaD commented Sep 4, 2024

  • Time zone and date picker don't have the same width
  • Center avatar + name
  • Avatar is way too big
  • Show the date picker opened permanently instead of toggled from a dropdown?
  • Scroll only the times and not the entire page (similar to calendly)
  • Mention time zone
  • [ ]

Changes to container

  • Width is fixed at 900px (size of the large modal)
  • margin-bottom: 50px so that the container is horizontally centered
  • use 3 columns, each column is fixed equal width
  • the entire modal does not scroll, only the time slot column
  • Changes for first column
  • avatar is 44*44px
  • Changes for second column
  • Change font size of "Select date" to normal size (only styling can be changed, semantically it can be h3)
  • disable dates for which no slots are available
  • Time zone picker is full width of the column
  • Changes to third column
  • Change font size of "Select slot" to normal size (only styling can be changed, semantically it can be h3)
  • Time slots are full width of the column
  • Time slots list is scrollable
@GretaD GretaD changed the title Use calendly design and layout? Use calendly design and layout Sep 4, 2024
@GretaD GretaD linked a pull request Sep 4, 2024 that will close this issue
@GretaD GretaD self-assigned this Sep 4, 2024
@GretaD GretaD added the 3. to review Waiting for reviews label Sep 4, 2024
@nimishavijay
Copy link
Member

nimishavijay commented Sep 6, 2024

For reference it can look like this:

image

Changes to container

  • Width is fixed at 900px (size of the large modal)
  • margin-bottom: 50px so that the container is horizontally centered
  • use 3 columns, each column is fixed equal width
  • the entire modal does not scroll, only the time slot column

Changes for first column

  • avatar is 44*44px
  • nice to have: show duration in normal body text with an icon below title: 🕦 30 minutes

Changes for second column

  • Change font size of "Select date" to normal size (only styling can be changed, semantically it can be h3)
  • show calendar instead of date picker
  • disable dates for which no slots are available
  • Time zone picker is full width of the column

Changes to third column

  • Change font size of "Select slot" to normal size (only styling can be changed, semantically it can be h3)
  • Time slots are full width of the column
  • Time slots list is scrollable

@jancborchardt
Copy link
Member

Very nice! :) One thing regarding the third column: Currently the vertical gap seems rather large, it could be reduced a little bit and instead there can be a larger gap for every hour as a little divider. In many cases like here, there would then be slots of 4 grouped together to get a better feeling for the time rather than a long list.

@GretaD
Copy link
Contributor Author

GretaD commented Sep 9, 2024

For reference it can look like this:

As i said on my pr, the full name of the month is not possible because the native datepicker has no option to stay always open, we have to use the normal datetimepicker for this case. See the screenshot on my pr how that can look otherwise. The rest of the points is already 90% done :) cc @nimishavijay @jancborchardt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
Status: 🏗️ At engineering
Development

Successfully merging a pull request may close this issue.

3 participants