Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APIs could be a bit friendlier to users #79

Open
daveman1010221 opened this issue Apr 19, 2023 · 1 comment
Open

APIs could be a bit friendlier to users #79

daveman1010221 opened this issue Apr 19, 2023 · 1 comment

Comments

@daveman1010221
Copy link

Hey, all.

Sorry about the title but that's the clearest way I could think to say it. There are a few areas, such as Query, where it would be nice to either be able to access struct fields as public or have accessor methods for the private fields. I can't really think of a reason the fields would need to be private, as the data belongs to the user of the library anyway.

Also, it would be nice to be able to perform comparison operations on some of the data structs, such as PartialEq. I'm willing to help out in this area. Do you all accept pull requests? Thanks.

@knutwalker
Copy link
Collaborator

Hi @daveman1010221

I agree that Query could expose it's data.
I'd prefer get_* and get_mut_* methods over public fields, as this makes it easier to maintain compatibility in case we need to change some internals later on.

If you still want to, feel free to open a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

2 participants