Updating Toolpad breaks the app in https://github.com/mui/mui-private/tree/master/tools-private

[oliviertassinari]

Steps to reproduce 🕹

Steps:

1. Go to https://github.com/mui/mui-private/tree/master/tools-private
2. Update Toolpad from 0.1.24 to 0.1.38
3. See how http://localhost:3000/_toolpad/app/pages/f303n5n is broken

• The date displayed is wrong

• Queries can't be added anymore, on a new page, it shows 500

[Janpot]

• The Date object bug was introduced in 0.1.28 => Date objects aren't transferred from the server to the client. Looks like right now it can only transfer JSON.

• The 500 was introduced in 0.1.34: Running with NODE_OPTIONS="--enable-source-maps --stack-trace-limit=1000" to get proper stack traces gives me:

  Error: Detected property constructor. This is a prototype pollution risk, please remove it from your object.
      at <anonymous> (~/mui-private/tools-private/node_modules/node_modules/superjson/src/plainer.ts:224:13)
      at <anonymous> (~/mui-private/tools-private/node_modules/node_modules/superjson/src/util.ts:45:52)
      at Array.forEach (<anonymous>)
      at forEach (~/mui-private/tools-private/node_modules/node_modules/superjson/src/util.ts:45:26)
      at walker (~/mui-private/tools-private/node_modules/node_modules/superjson/src/plainer.ts:218:3)
      at <anonymous> (~/mui-private/tools-private/node_modules/node_modules/superjson/src/plainer.ts:229:29)
      at <anonymous> (~/mui-private/tools-private/node_modules/node_modules/superjson/src/util.ts:45:52)
      at Array.forEach (<anonymous>)
      at forEach (~/mui-private/tools-private/node_modules/node_modules/superjson/src/util.ts:45:26)
      at walker (~/mui-private/tools-private/node_modules/node_modules/superjson/src/plainer.ts:218:3)
      at <anonymous> (~/mui-private/tools-private/node_modules/node_modules/superjson/src/plainer.ts:229:29)
      at <anonymous> (~/mui-private/tools-private/node_modules/node_modules/superjson/src/util.ts:45:52)
      at Array.forEach (<anonymous>)
      at forEach (~/mui-private/tools-private/node_modules/node_modules/superjson/src/util.ts:45:26)
      at walker (~/mui-private/tools-private/node_modules/node_modules/superjson/src/plainer.ts:218:3)
      at <anonymous> (~/mui-private/tools-private/node_modules/node_modules/superjson/src/plainer.ts:229:29)
      at <anonymous> (~/mui-private/tools-private/node_modules/node_modules/superjson/src/util.ts:45:52)
      at Array.forEach (<anonymous>)
      at forEach (~/mui-private/tools-private/node_modules/node_modules/superjson/src/util.ts:45:26)
      at walker (~/mui-private/tools-private/node_modules/node_modules/superjson/src/plainer.ts:218:3)
      at <anonymous> (~/mui-private/tools-private/node_modules/node_modules/superjson/src/plainer.ts:229:29)
      at <anonymous> (~/mui-private/tools-private/node_modules/node_modules/superjson/src/util.ts:45:52)
      at Array.forEach (<anonymous>)
      at forEach (~/mui-private/tools-private/node_modules/node_modules/superjson/src/util.ts:45:26)
      at walker (~/mui-private/tools-private/node_modules/node_modules/superjson/src/plainer.ts:218:3)
      at <anonymous> (~/mui-private/tools-private/node_modules/node_modules/superjson/src/plainer.ts:229:29)
      at <anonymous> (~/mui-private/tools-private/node_modules/node_modules/superjson/src/util.ts:45:52)
      at Array.forEach (<anonymous>)
      at forEach (~/mui-private/tools-private/node_modules/node_modules/superjson/src/util.ts:45:26)
      at walker (~/mui-private/tools-private/node_modules/node_modules/superjson/src/plainer.ts:218:3)
      at <anonymous> (~/mui-private/tools-private/node_modules/node_modules/superjson/src/plainer.ts:229:29)
      at <anonymous> (~/mui-private/tools-private/node_modules/node_modules/superjson/src/util.ts:45:52)
      at Array.forEach (<anonymous>)
      at forEach (~/mui-private/tools-private/node_modules/node_modules/superjson/src/util.ts:45:26)
      at walker (~/mui-private/tools-private/node_modules/node_modules/superjson/src/plainer.ts:218:3)
      at <anonymous> (~/mui-private/tools-private/node_modules/node_modules/superjson/src/plainer.ts:229:29)
      at <anonymous> (~/mui-private/tools-private/node_modules/node_modules/superjson/src/util.ts:45:52)
      at Array.forEach (<anonymous>)
      at forEach (~/mui-private/tools-private/node_modules/node_modules/superjson/src/util.ts:45:26)
      at walker (~/mui-private/tools-private/node_modules/node_modules/superjson/src/plainer.ts:218:3)
      at <anonymous> (~/mui-private/tools-private/node_modules/node_modules/superjson/src/plainer.ts:229:29)
      at <anonymous> (~/mui-private/tools-private/node_modules/node_modules/superjson/src/util.ts:45:52)
      at Array.forEach (<anonymous>)
      at forEach (~/mui-private/tools-private/node_modules/node_modules/superjson/src/util.ts:45:26)
      at walker (~/mui-private/tools-private/node_modules/node_modules/superjson/src/plainer.ts:218:3)
      at SuperJSON2.SuperJSON2.serialize (~/mui-private/tools-private/node_modules/node_modules/superjson/src/index.ts:35:20)
      at SuperJSON2.SuperJSON2.stringify (~/mui-private/tools-private/node_modules/node_modules/superjson/src/index.ts:81:32)
      at <anonymous> (~/mui-private/tools-private/node_modules/@mui/toolpad/src/server/rpc.ts:87:31)
  
  

  Looks to be around the same area, in serialization/deserialization.

Will investigate further

[Janpot]

Ok, for the 500 we are having trouble transferring the typescript interface that describes the MySQL result. it contains a "constructor" property. This is new behavior in superjson. Very unnecessary

I don't immediately have a way to fix this besides reverting the update or writing our own smart serialization logic. I'm opening some issues in the hope thatw e can fix this without dropping a serialization library:

• devalue is too strict about what can be serialized with custom types Rich-Harris/devalue#71
• superjson throws on constructor property flightcontrolhq/superjson#279

[Janpot]

Fixes in:

• Fix crash when function result type contains a constructor property #2941
• Fix Date serialization in serverless functions #2942