Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change prometheus config from additional scrape config to probe #2067

Open
dbason opened this issue Apr 9, 2024 · 1 comment
Open

Change prometheus config from additional scrape config to probe #2067

dbason opened this issue Apr 9, 2024 · 1 comment
Assignees

Comments

@dbason
Copy link

dbason commented Apr 9, 2024

Is your feature request related to a problem? Please describe.
Our infrastructure is handled with GitOps and as such our Prometheus object is statically defined. Modifying a global object breaks this pattern.

Describe the solution you'd like
Rather than using additional scrape configs would a Probe be an option? This should handle the single endpoint nature of cluster metrics. It might also be nice to include a ServiceMonitor for scraping node metrics

Describe alternatives you've considered
We have considered bootstrapping the minio additional scrape config however this would be an anti pattern as the secret and naming is minio specific for a global object

Additional context
Add any other context or screenshots about the feature request here.

@dbason
Copy link
Author

dbason commented Apr 10, 2024

We have manually created a probe to confirm this works:

spec:
  authorization:
    credentials:
      key: token
      name: token-secret
    type: Bearer
  jobName: minio-tenant-test-job
  prober:
    path: /minio/v2/metrics/cluster
    scheme: https
    url: minio.test.svc.cluster.local
  targets:
    staticConfig:
      static:
      - minio.test.svc.cluster.local
  tlsConfig:
    ca:
      configMap:
        key: ca.crt
        name: kube-root-ca.crt

If this is something that people agree is a good idea I could look at creating a PR for this. It would need the ability to add arbitrary labels to the probe incase there is a probeSelector on the prometheus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants