Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPIR-V] Teach DXC about component decorations #6831

Open
s-perron opened this issue Jul 29, 2024 · 1 comment
Open

[SPIR-V] Teach DXC about component decorations #6831

s-perron opened this issue Jul 29, 2024 · 1 comment
Assignees
Labels
bug Bug, regression, crash spirv Work related to SPIR-V
Milestone

Comments

@s-perron
Copy link
Collaborator

Description

Two inputs or outputs can have the same location as long as they have different components. DXC is currently unaware of the component and will issue an error if two inputs have the same location. This should be updated, so that we can add the component decoration.

Steps to Reproduce

https://godbolt.org/z/EYf4bEce5

Actual Behavior
The compiler issues an error. We would expect no error, and color should have two decoration. A location decoration setting its location to 0, and a component decoration setting the component to 1.

Environment

  • DXC version latest
  • Host Operating System all
@s-perron s-perron added bug Bug, regression, crash spirv Work related to SPIR-V needs-triage Awaiting triage labels Jul 29, 2024
@s-perron s-perron self-assigned this Jul 29, 2024
@damyanp damyanp removed the needs-triage Awaiting triage label Jul 30, 2024
@s-perron s-perron modified the milestones: Dormant, HLSL 202x Aug 23, 2024
@s-perron
Copy link
Collaborator Author

@cassiebeckley While you are looking into how to implement vk::location in clang, think about how to incorporate the component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug, regression, crash spirv Work related to SPIR-V
Projects
Status: New
Status: Triaged
Development

No branches or pull requests

3 participants